From 087dec7fcfb18fc4e8a0ec68c9c0a84cb9f03e69 Mon Sep 17 00:00:00 2001 From: Davide Caratti Date: Fri, 16 Sep 2016 10:30:00 +0200 Subject: [PATCH] tc: don't accept qdisc 'handle' greater than ffff since get_qdisc_handle() truncates the input value to 16 bit, return an error and prompt "invalid qdisc ID" in case input 'handle' parameter needs more than 16 bit to be stored. Signed-off-by: Davide Caratti Acked-by: Phil Sutter --- tc/tc_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index 15e49b7ba..24ca1f1c1 100644 --- a/tc/tc_util.c +++ b/tc/tc_util.c @@ -82,7 +82,7 @@ int get_qdisc_handle(__u32 *h, const char *str) if (strcmp(str, "none") == 0) goto ok; maj = strtoul(str, &p, 16); - if (p == str) + if (p == str || maj >= (1 << 16)) return -1; maj <<= 16; if (*p != ':' && *p != 0) -- 2.47.2