From 08bbc3dfd84234c3cd691e43ff17ed36e2396d76 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sun, 20 Jan 2008 19:04:06 +0000 Subject: [PATCH] clean up a little close() silliness --- lib/sqlalchemy/engine/base.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/sqlalchemy/engine/base.py b/lib/sqlalchemy/engine/base.py index f2a1cd2864..7692174543 100644 --- a/lib/sqlalchemy/engine/base.py +++ b/lib/sqlalchemy/engine/base.py @@ -627,7 +627,7 @@ class Connection(Connectable): The underlying DB-API connection is literally closed (if possible), and is discarded. Its source connection pool will - typically lazilly create a new connection to replace it. + typically lazily create a new connection to replace it. Upon the next usage, this Connection will attempt to reconnect to the pool with a new connection. @@ -819,17 +819,19 @@ class Connection(Connectable): """Close this Connection.""" try: - c = self.__connection + conn = self.__connection except AttributeError: return if not self.__branch: - self.__connection.close() - self.__connection = None + conn.close() self.__invalid = False del self.__connection def scalar(self, object, *multiparams, **params): - """Executes and returns the first column of the first row.""" + """Executes and returns the first column of the first row. + + The underlying result/cursor is closed after execution. + """ return self.execute(object, *multiparams, **params).scalar() -- 2.47.3