From 09dede4656cd9a2297d3c2060c945c4a7ea7780d Mon Sep 17 00:00:00 2001 From: Angel Baez <51308340+abaez004@users.noreply.github.com> Date: Wed, 7 Feb 2024 10:34:48 -0500 Subject: [PATCH] Rearrange terms in gf_mul to prevent segfault CLA: trivial Reviewed-by: Tom Cosgrove Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/23512) (cherry picked from commit 76cecff5e9bedb2bafc60062283f99722697082a) --- crypto/ec/curve448/arch_64/f_impl64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/ec/curve448/arch_64/f_impl64.c b/crypto/ec/curve448/arch_64/f_impl64.c index 10a9b065e55..9e2f0c66d50 100644 --- a/crypto/ec/curve448/arch_64/f_impl64.c +++ b/crypto/ec/curve448/arch_64/f_impl64.c @@ -45,9 +45,9 @@ void gf_mul(gf_s * RESTRICT cs, const gf as, const gf bs) accum0 += widemul(a[j + 4], b[i - j + 4]); } for (; j < 4; j++) { - accum2 += widemul(a[j], b[i - j + 8]); - accum1 += widemul(aa[j], bbb[i - j + 4]); - accum0 += widemul(a[j + 4], bb[i - j + 4]); + accum2 += widemul(a[j], b[i + 8 - j]); + accum1 += widemul(aa[j], bbb[i + 4 - j]); + accum0 += widemul(a[j + 4], bb[i + 4 - j]); } accum1 -= accum2; -- 2.47.2