From 0a4f27f3a607fecc2c2c1ee0464a9c0a02af555b Mon Sep 17 00:00:00 2001 From: Tom Hromatka Date: Tue, 27 Apr 2021 16:40:39 +0000 Subject: [PATCH] api.c: Fix strncpy() truncation warning MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fix the following strncpy() string truncation warning: In function ‘strncat’, inlined from ‘cgroup_get_cgroup’ at api.c:3153:3: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:136:10: warning: ‘__builtin___strncat_chk’ output may be truncated copying between 0 and 4095 bytes from a string of length 4095 [-Wstringop-truncation] 136 | return __builtin___strncat_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Tom Hromatka --- src/api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/api.c b/src/api.c index 51c4779e..4a980a15 100644 --- a/src/api.c +++ b/src/api.c @@ -3151,6 +3151,7 @@ int cgroup_get_cgroup(struct cgroup *cgroup) path_len = strlen(path); strncat(path, cgroup->name, FILENAME_MAX - path_len - 1); + path[sizeof(path) - 1] = '\0'; if (access(path, F_OK)) continue; -- 2.47.2