From 0afb4e96b1cfb67b9ad7d344f3463b4af91b0616 Mon Sep 17 00:00:00 2001
From: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Date: Wed, 27 Jun 2018 15:21:12 +0200
Subject: [PATCH] serialtweaker: add comment on why empty SOA-EDIT is "wrong"

---
 pdns/serialtweaker.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pdns/serialtweaker.cc b/pdns/serialtweaker.cc
index 7b1d7c7b9f..bd04c344df 100644
--- a/pdns/serialtweaker.cc
+++ b/pdns/serialtweaker.cc
@@ -72,6 +72,9 @@ uint32_t calculateEditSOA(uint32_t old_serial, const string& kind, const DNSName
   else if(!kind.empty()) {
     g_log<<Logger::Warning<<"SOA-EDIT type '"<<kind<<"' for zone "<<zonename<<" is unknown."<<endl;
   }
+  // Seen strictly, this is a broken config: we can only come here if
+  // both SOA-EDIT and default-soa-edit are set to "", but the latter
+  // should be set to "NONE" instead.
   return old_serial;
 }
 
-- 
2.47.2