From 0b3ef9c1a619f7011762f5dd24d972dc8c093e75 Mon Sep 17 00:00:00 2001 From: Jukka Kurkela Date: Fri, 12 Jun 2020 01:21:10 +0300 Subject: [PATCH] Replace ineffective test with a fixture (#7491) --- test/fixture.js | 2 +- test/fixtures/scale.linear/tiny-numbers.js | 18 ++++++++++++++ test/fixtures/scale.linear/tiny-numbers.png | Bin 0 -> 18280 bytes test/specs/scale.linear.tests.js | 26 ++------------------ 4 files changed, 21 insertions(+), 25 deletions(-) create mode 100644 test/fixtures/scale.linear/tiny-numbers.js create mode 100644 test/fixtures/scale.linear/tiny-numbers.png diff --git a/test/fixture.js b/test/fixture.js index 745f0bdbd..d00eb3f7d 100644 --- a/test/fixture.js +++ b/test/fixture.js @@ -44,7 +44,7 @@ function specFromFixture(description, inputs) { loadConfig(input, function(json) { var chart = utils.acquireChart(json.config, json.options); if (!inputs.png) { - fail('Missing PNG comparison file for ' + inputs.json); + fail('Missing PNG comparison file for ' + input); done(); } diff --git a/test/fixtures/scale.linear/tiny-numbers.js b/test/fixtures/scale.linear/tiny-numbers.js new file mode 100644 index 000000000..63c720e68 --- /dev/null +++ b/test/fixtures/scale.linear/tiny-numbers.js @@ -0,0 +1,18 @@ +// Should generate max and min that are not equal when data contains values that are very close to each other + +module.exports = { + config: { + type: 'scatter', + data: { + datasets: [{ + data: [ + {x: 1, y: 1.8548483304974972}, + {x: 2, y: 1.8548483304974974}, + ] + }], + }, + }, + options: { + spriteText: true + } +}; diff --git a/test/fixtures/scale.linear/tiny-numbers.png b/test/fixtures/scale.linear/tiny-numbers.png new file mode 100644 index 0000000000000000000000000000000000000000..d3c0f75ab514032dffaeae3922501129c5aad5cf GIT binary patch literal 18280 zc-rlpX;hM1+sALw((2^Uq^39=E$dX8S~;L#S(#bd@SLn1)5^+}Z~{lv1~mto%uI!P ztn8f1OmjvtMMzO7shm+EB@#gd5k=vJp7Xq)-_P%YwOB53|L*(R`@Z(I|J$|yWF7PN zSiN%NN&o;>dmh?<0sugO@~yR8@k50AvH$>Pfam_b|3U>$m8^O{75irm+RXQ+hRuAw z{`=-z6J@_YKmXTWz9r9sNZ0*iDrF1$-lb`HfQiv#&db1t>6b5-PPFT)7oylUJMwHiAcB(MHveceXO z4FKt;0vg}IX#wAc;axVrsr~1p7B^svnuZym_%#^3#try3W?B+t_^Yj1D)8yQt(+}W zf!A#?XM){-+5&1%)PJ=B(qaz*YNs>MF)0`Rxe3Tk)2u?crY|(-9h;gsyQlHuh*79N z;b8eT-?boJgX;xqJs>SEQ9}$4C8EEz_L6K5E@mhq49?XZ)oR%|?~d5ryD6;@7&>Pq zpRys$Q%%+SI^@UvUA4AvR)nOf#l>rESmkCMNH}NJ_;(}5mU(%lMzEE%?OLqa9rIM+ z{Fb|EEqUe@r-5dBQr$(ef9`tp&o?9ksTlz254!nEJ`094^#A#^vdfNGfmlPrE0ynfFLGay{ZCsp5Sd8`=K*IBT& zzELI0`*2LLK}Mj#>k7zqi_qSz!Wo3u`}DI8u~o~>Y%id8$nAGf8hC$dEr_vqbpD<0 zX&uEaXQzE9kp8bUBs-r}FBGs6+=Evuqi-?IdQ}&>Vj9shDfXe+Xs1Q^1Rqd4t$6i` zVOU&+y>8!yf&kqQC1W}tVwKOX0<4H@P)|%(8rHFelZ|ZSj4)D4V zw%&K0G67Cmm@OL}9Fd7p-Qj`ujJf8yTw2nEJw-NZlQg!96#-8iM0I!t+VNt_Ai2JT zg|DoNHfA!nARXgwIR8C3CAoVE8?vj3L0e%a{4jdyVl$B-1esE zvx`PhX+O;*tR(iE60myf7D*VW^;Fib)BK?%vIE z<;T-dt!uFr{j^68_SS^Ql&0yMHpXGa2$JN72h4fT)xL`U+2Xk--6!|GoiF2O-@w88 zK}iDC=j^~;jKv8Dc!PZqrvcAg|Mn4a%Xdz3G}X{1MUYMYs|@R`4V8=@)hch~HDnE+ zI5-%s=*LBI{+B>dQF_@ixr;8NUXEyRP- zC)c$HL~?gCW~N(a%P>D>Zbx~q@=53+#bvmZg^RFIMwdb50HwRUrDw8Ua(l-T<0N+G z0fJZ0_V%!1!aj`GvGR<3&66B_sC!H9beX zL0yr*IVq<*L_e*GY=ATh9dab~%}%@$kK2-}e_km^wV~(73v7}kZKfu3^|a(YjqX8_ z!7d4T9)c|89Km0na1;;w3&>j*GG_;V1RBXEk19d`nRCR=UhF71|0DRVgHBZR7^rRFH*R#`b^LKf;m zajqFAm=xBJR&|r#WJf(Or(>zR+6KmnKo7koS=t zP#_8LflR&UY)!p`%TFQG&@y2Ws=J(Z*uSRz2o`iK{GV_hXfP|#E(?S!9o5+mdeTmV zP##^)?*PF36g%`6VXlc^V)EH0c|W8v#C$Dc&Cpt$gvhyuG(JU`Ze3O2+PM=xamB`= z(WHvq%c7z=da2{h4nDv{Kmj~OSY$y}NA)%`cDn}XvcbfTTOY=58ATc>u3$w9H4#4Q z#(HN?)-{FkDk;{;Bma_Whvrb$*3TNJeO@F$lSWV0CqIGt^$bSmAPQ_rU$dLn*U|@l z0H$|x+;W0&D53Za`p46ZJjd@%5`3EEz(lwI)cA&~=yJA;+9PDZLm9q(#y;_HbB%L? z6*m!uQ?B;$8lz8aNw+%1<<}{)X#-Ye>~vze*!Ko4DQY^6b|r37o?}~HH=l0r*)VIs z+PC}aD`T}|wAi;X8o>;&v0vAp7&fO#8Tk8vy$w6N-`p6nZ=9Ri#{J=j2bl%tPrJiJ z?nULTVr&-haL76`kg zf%to45*8*%a3Qq{B6&_|<37JxB{U73@AQpqsKS-7Dn#?>*asngUHgGkRne5dTgqs* zUHCUlRMvxYG&M8vB$c3lhX3gSJY3m=cj&DD@$c*xb89kvLEDq$at)N>lgRYyqy+y)jU?UF!+&uwFT!m10lSW^(Q>O%|2A_W zV^8M?O|_R_3T2lPHdtu5sc%XH&O?HC1jSt{HC7@eDnx~-5EY_AREP>uAu2?Ls1OyR zLR5$fQ6VZsg{Tk}qC!;2{|{ty(U}MTJqw^3Jr$xtREP>uAu2?Ls1OyRLR5$fQ6VZs zg{Tk}qC);3Bc2Zm)d%8n70(l45PB=W;3M-P1OH<7%{K_9t%oN-}~Q`vxV?)`#G-SQP)tZ}^JRm+`?Yg|Mx>E`(b%7|E)sZJH8EcgW828oI2Jf~=wEw|@1kq5oX z;LR4mVK|1~I!BN%Avn(q@_O+TyIDB-JdPX&6&7AVFQOO8=$w<@P8aafVZKRiGEdIiy{&mCZ87& zt)Pe`e&WcW$o|(k^F3Glb~0q*T6hE2CvkvIDm7jD!O4qf%r!53eVcdR2O5tT_c-BV?%uq~Na}Qsa8z^7s#n63V$;Jskp0f1O0)29uiMZk&8=IKd$e1ms^G$o! z-V;s1(TOfU_Uddjl}pI%s54Vt(Nw3f1#pN=M>eXH7nz9po_@vB8zFWbZs8A^v z@nM;M4%wB5U@46pG!)66WEfU#JKVqcHE8LpTI;)>Dr#( zU645YD#(@UJo(xa#MDL$lnxda2A0xbfo4NSoH{y{4je&4Z&T!AkIhn#NcuV^KoPhs zIB8Vf^wD`MiE$$L9qWxEXHbd{>ayC91nF>=0JqqIJ5sCz;Z{W0*`H@;2Q4x!ui%!r zVPyEyH+U{gS_Lc8*kTSO=GdkrvO)PRH6r0al={pGs!S+xD&wv{dO zY#d?wrHAVkm+$5}h6uK!4Vv5Z!!TKT5kt1OG`7nOg%?Q{ys!R|Bx`H5(gTAeW}C*+%IQ7) z_LA>6^#dJO99y*FNpQkqc8)S}=z2N%~WxZ_6>XoaZGADf7jGd6CCr&Uk&y3Rp9R7G;+z3e)IHA z0aKrVa`u-+!{(w{{j?M@isHwxTjFP1H(Xle@nt+z=Si#`I3bT+>b{Ywy_I)Ne^rap zOXFXWUACKfC&eW|uXo$`i{h7w&-pu==mA}!jMx=fPNS*nFGd85LYnDZUd`98p2#6!6DE2=Sx9lLDN+%KwPm3X%yHt31$yGV2I3GnfeT4zfiP>x6WVSrhIGUnxZ zP!V?iE@a~wT`Nj^$)FWfkR_-^OKa(bB^h5Xi}C)T=V5GHqNR^a5**rP0=C(Z8gK8L zSZ_9$3r`AN^8hW$KtIB&W6J)xXay=4HN}H=@*9ZeVkDjgrt_sRxe&&(#l&|>-kD0@ zaklJpS%aY{iVLk6E0=%tfL3x6u4Wes8p$hen4c4@JGfX5PaGU1DP|N#Hx*L;>F>cj zTP86V^&TxfQ0S;WGiiIG`Yzx7mqRkn;@Z3ctCH(8_y+&7cN=sf6 zYg4@WQNg|Ht!+C%JkE8KzHDjho1i_kDCC&k6FdqX;jtwhMbj*SmTGkGOB#kWsuo^&s0IC z!*{bls6K6${8WaL&98rpYJXAC+KzX$Y?AUCeQffxt0vgp#Z5P;P5#EWFzgonpaRtF zUgL;Ib4{q-?nC`#zP^WJ%2aPk1ie%o-@Azy!^&*svR!BHVvNyCy=d1C>UcpAw8LGC z29vR1-i7_WHIEEoR^C5d0qnPAY%$0Fo>`{8PlHL7hc{$Q+9{^Jv!&8? z^UvTbdg5g|PVPV>dPcGXMgQi^b5R{ZE|sp|@3@nqand19yZ{hSCzG_hw!DRSu$Rk=6` z26~(05;y@}S#neMp``I`L51F}*=26bP3cua-G?T-PbbLQuY{5K`frJuWtPl%x#aN* zf98c$J&c2O-Gc&vI_wrcFS4%nYEj6O2akWrldXUvO7@Eakada>`&_<(4;Z`!Wx5X{ z8|Wo3*o9%pX~BTdQO}wuVSYxttPD&d8xm+yN@Jp-`kW#*3ZCC?G4DW_?`GM^m^L+% zB}Lw#IKf&6hd#g*WxWI&jq&~SwFqLfG-y31eG@kUUnIeEln-H;>(M29;i*<}`+4Gk zotg!2^pExzzwB3aufLja1-^#2jU!V)O2?DYng4Y>DOyE5hdsu&YpH#58?@3*eIvH2 zc?f^C^rhNfODRs?{1PYTz{X2b4N%2b8S&dpL^ZA`nUPWRH&NlOZ>IBI9#^bS=@Em~aP#=FQmK}O z^E1E7s1QGq;)06@HU`A`J$R*uMNMARxJ)%&2W^a zM86dF*d(XVc6g1(lh#a1`Mnk{X)8m|mQnXZY1|a?GAPLb@#FdQ3`n~XtR3P;DuT8{ z97(+isFh}n-ru1fze7)RzSTC*ZpdT~+pv-?nBAq!h;mkw88g{{nOpEp9ft~|{5Y88 zb{ao9j(;1x4z9fceEX^|G<(xl#t2Ko!r&N7(PF((FT(>F%qn+==!L^koc2ck!34=z zhL7oUM*iJsqjmhjHT)fG;SnZ$*R?p#n%cc3^GU*@5&z79EShS?Q?-ygKo?PWVieo%6TbvyeIaWI73b4!C; z&&KXRT1Vnp-Hl8tjKNH3yS17nqWhTYpe1d-{`rz0)2MB{(HMn*I?`W`j8q$Y9A17# z%i8>gKnk6@>|4Ujzv3b*oAfUOM_ihslQA-93QFK1!TpQDIQenLV}j-69S~FmEX3 z6VQ~BRZziJoIom*66DfMj4(x^kRiSR^GzK~Z+cUKf92M}YS=q>tCEcDQ~teboz(*Fp_5u?^HUrrts$z|g67?+3m@jqu4Cu*EUXAy4iF{GW;J z(nHxa^DNr4EKSP{a9m%E<#~>;)(ID_!jeYg5R=+L!2?TB1&LQ&Oa9sH)6SYp?2TZKwHA{IB%gjt7xDAu# zbn}io9g3(iG9Aa!RL);_F-hMoCiekMUF47%nI49?gvJ6xZ0KAe^!j*@mkk&}Ju2FQ zJ$(CZIb>pJdAk#!m}32V(7Pz0>b%vSN zzekp`!ruX1G8m}Bm3O?ikM<}(yx!;Heqaxb;u?A04y4OIK(xqrOxp%ccY+EKy#dIG zZ9o;4SX!Y7(R2yyFr;akG))Xc)J*2ibvrcEy*ydRo7SW{;-$~5TrYRF3-O3AX3*SS zk76%;S4Ou-fOGV;>mz!m!s97^r0XW4C*maL{Y$@eI4chl*$|LbcJpCl?m^&NU&(YH zzJWUPrq=?fBKRCs$jG>)g$pjvXQ;^LXlEU>x>$lh``}>!I-RC-#N!0>^4+@o?m*4Z z;*U;y+r-F7ZB9tA zcEL(9Z83<-6UH0)Ns>6hnCB({lklaKqzRLJ;N0~pZdvE!+TL*lq5VO*d3@+`XvhLU z*hRXm*7aER(8TsfbEu(OCU0mmaBd*R=)L4Jr97z|Kht>=)e&kup6RPjtUt6Zxt(qy zI6-gsQFEEArw#8j8?+wWh}U5}^^I5Paf&x{o}4%$WzdCJk2j-MjBYI}wzF=QFa;iH z#qt(@f_3oKwY{fHy0e(XBDv{Lb+M>C~gObC1n`58`jxd1nDF_T$@T(?5^mZ zexD0bB0C7gN#=TfRI$I6YT5QFrqcjpbGP&Rp_9P7ljfh5CVx?9ri72;!L)_93`!Kc zUOHunsWHq0pY;YFGM2Y@lqz?kF)=&5-zP87aSWMd3*8$MF{aFD5gu*4?2+rs(~B*Z zGNfqYbrtn7)oDRg26Ih@EnB|QY zn*fTARMzelJeCB%4~)FNCvwQK=|niEm)rgE;_o}9@+$8GP;5xHrlptkI>7ycqzv*q z1<-NfnKn)6*NA8CF)w?bMtoK%)fxTEG5rz8%MYR?6-EN`GuS`!W E06oY?tN;K2 literal 0 Hc-jL100001 diff --git a/test/specs/scale.linear.tests.js b/test/specs/scale.linear.tests.js index 4f4c31dd9..c011f666c 100644 --- a/test/specs/scale.linear.tests.js +++ b/test/specs/scale.linear.tests.js @@ -3,6 +3,8 @@ function getLabels(scale) { } describe('Linear Scale', function() { + describe('auto', jasmine.fixture.specs('scale.linear')); + it('Should register the constructor with the scale service', function() { var Constructor = Chart.scaleService.getScaleConstructor('linear'); expect(Constructor).not.toBe(undefined); @@ -1106,30 +1108,6 @@ describe('Linear Scale', function() { expect(chart.scales.x.max).toEqual(0); }); - it('Should generate max and min that are not equal when data contains values that are very close to each other', function() { - var chart = window.acquireChart({ - type: 'scatter', - data: { - datasets: [{ - data: [ - {x: 1, y: 1.8548483304974972}, - {x: 2, y: 1.8548483304974974}, - ] - }], - }, - options: { - scales: { - y: { - type: 'linear', - } - } - } - }); - - expect(chart.scales.y).not.toEqual(undefined); // must construct - expect(chart.scales.y.max).toBeGreaterThan(chart.scales.y.min); - }); - it('Should get correct pixel values when horizontal', function() { var chart = window.acquireChart({ type: 'horizontalBar', -- 2.47.2