From 0d4ca79d4fc3c42b3970190f96781ed4f2552b32 Mon Sep 17 00:00:00 2001 From: Arne Schwabe Date: Fri, 23 Oct 2020 13:34:30 +0200 Subject: [PATCH] Remove explicit setting of peer_id to false Almost everywhere in OpenVPN we rely on zero initialisation to initialise all bool attributes to false. ret is cleared by ALLOC_OBJ_CLEAR(ret, struct tls_multi); Having this one variable treated different is a bit confusing. Signed-off-by: Arne Schwabe Acked-by: Gert Doering Message-Id: <20201023113431.26691-4-arne@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21218.html Signed-off-by: Gert Doering --- src/openvpn/ssl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 97e2c6194..53dad9ffa 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -1216,9 +1216,6 @@ tls_multi_init(struct tls_options *tls_options) ret->key_scan[1] = &ret->session[TM_ACTIVE].key[KS_LAME_DUCK]; ret->key_scan[2] = &ret->session[TM_LAME_DUCK].key[KS_LAME_DUCK]; - /* By default not use P_DATA_V2 */ - ret->use_peer_id = false; - return ret; } -- 2.47.2