From 0d64317fa6e1716b40fa2c787810775449c09d09 Mon Sep 17 00:00:00 2001
From: "dkl%redhat.com" <>
Date: Mon, 21 Jul 2008 08:21:38 +0000
Subject: [PATCH] =?utf8?q?Bug=20445885=20=C3=A2=C2=80=C2=93=20User.login?=
 =?utf8?q?=20should=20ThrowUserError=20when=20called=20with=20incorrect=20?=
 =?utf8?q?parameters=20Patch=20by=20David=20Lawrence=20<dkl@redhat.com>=20?=
 =?utf8?q?-=20r/a=3Dmkanat?=
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

---
 Bugzilla/WebService/User.pm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/Bugzilla/WebService/User.pm b/Bugzilla/WebService/User.pm
index d0ce706f04..cab2c5182b 100755
--- a/Bugzilla/WebService/User.pm
+++ b/Bugzilla/WebService/User.pm
@@ -43,7 +43,13 @@ use constant LOGIN_EXEMPT => {
 sub login {
     my ($self, $params) = @_;
     my $remember = $params->{remember};
-    
+
+    # Username and password params are required 
+    foreach my $param ("login", "password") {
+        defined $params->{$param} 
+            || ThrowCodeError('param_required', { param => $param });
+    }
+
     # Convert $remember from a boolean 0/1 value to a CGI-compatible one.
     if (defined($remember)) {
         $remember = $remember? 'on': '';
@@ -189,6 +195,10 @@ The username does not exist, or the password is wrong.
 The account has been disabled.  A reason may be specified with the
 error.
 
+=item 50 (Param Required)
+
+A login or password parameter was not provided.
+
 =back
 
 =back
-- 
2.47.2