From 0e3dd5bce80f084ead392e4adc997c75605d1df5 Mon Sep 17 00:00:00 2001 From: Marcos Paulo de Souza Date: Sun, 1 Aug 2021 20:35:49 -0300 Subject: [PATCH] btrfs: send: simplify send_create_inode_if_needed The out label is being overused, we can simply return if the condition permits. No functional changes. Reviewed-by: Su Yue Reviewed-by: Nikolay Borisov Signed-off-by: Marcos Paulo de Souza Reviewed-by: David Sterba Signed-off-by: David Sterba --- fs/btrfs/send.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index 72f9b865e8479..afdcbe7844e0e 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -2720,19 +2720,12 @@ static int send_create_inode_if_needed(struct send_ctx *sctx) if (S_ISDIR(sctx->cur_inode_mode)) { ret = did_create_dir(sctx, sctx->cur_ino); if (ret < 0) - goto out; - if (ret) { - ret = 0; - goto out; - } + return ret; + else if (ret > 0) + return 0; } - ret = send_create_inode(sctx, sctx->cur_ino); - if (ret < 0) - goto out; - -out: - return ret; + return send_create_inode(sctx, sctx->cur_ino); } struct recorded_ref { -- 2.47.2