From 0e684fda343a050de727f360e9b4d21a4e031f4a Mon Sep 17 00:00:00 2001 From: bert hubert Date: Tue, 28 Nov 2017 10:50:24 +0100 Subject: [PATCH] quote server-id. This stops us from breaking serving chaos txt id.server if your server has a dash or a dot or an underscore in its name. --- pdns/packethandler.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc index 3b3bcbd161..028f6d32a9 100644 --- a/pdns/packethandler.cc +++ b/pdns/packethandler.cc @@ -274,7 +274,10 @@ int PacketHandler::doChaosRequest(DNSPacket *p, DNSPacket *r, DNSName &target) r->setRcode(RCode::Refused); return 0; } - rr.dr.d_content=DNSRecordContent::mastermake(QType::TXT, 1, id); + string tid=id; + if(!tid.empty() && tid[0]!='"') // see #6010 however + tid = "\"" + tid + "\""; + rr.dr.d_content=DNSRecordContent::mastermake(QType::TXT, 1, tid); } else { r->setRcode(RCode::Refused); -- 2.47.2