From 100abbc650a075936aa2700a7b19790f7519fa23 Mon Sep 17 00:00:00 2001 From: Benjamin Berg Date: Mon, 7 Feb 2022 17:34:21 +0100 Subject: [PATCH] oom: Cleanup of information dump code after kill This is a follow up to 29f4185a9cdc ("oomd: Dump top offenders after a kill action") to clean up the code a bit for review comments that happened after the code had been merged already. --- src/oom/oomd-util.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/oom/oomd-util.c b/src/oom/oomd-util.c index 4d05f57a692..77718d9c9e3 100644 --- a/src/oom/oomd-util.c +++ b/src/oom/oomd-util.c @@ -227,7 +227,7 @@ static int dump_kill_candidates(OomdCGroupContext **sorted, int n, int dump_unti f = open_memstream_unlocked(&dump, &size); if (!f) - return -errno;; + return -errno; fprintf(f, "Considered %d cgroups for killing, top candidates were:\n", n); for (int i = 0; i < dump_until; i++) @@ -237,8 +237,6 @@ static int dump_kill_candidates(OomdCGroupContext **sorted, int n, int dump_unti if (r < 0) return r; - f = safe_fclose(f); - return log_dump(LOG_INFO, dump); } -- 2.47.3