From 10a6e01eaa9e340c4edafa771c001986bdcdcfc6 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Mon, 27 Nov 2017 12:36:21 +0000 Subject: [PATCH] boot/shim: fix char ** vs char * mismatch This code cannot have ever worked ;( Found by coverity, obvious when the type is not obfuscated to void*. --- src/boot/efi/shim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/boot/efi/shim.c b/src/boot/efi/shim.c index 6da9ee889f9..d66b39be236 100644 --- a/src/boot/efi/shim.c +++ b/src/boot/efi/shim.c @@ -162,7 +162,7 @@ static EFIAPI EFI_STATUS security_policy_authentication (const EFI_SECURITY_PROT EFI_DEVICE_PATH *dev_path; EFI_HANDLE h; EFI_FILE *root; - VOID *file_buffer = NULL; + CHAR8 *file_buffer = NULL; UINTN file_size; CHAR16 *dev_path_str; @@ -182,7 +182,7 @@ static EFIAPI EFI_STATUS security_policy_authentication (const EFI_SECURITY_PROT dev_path_str = DevicePathToStr(dev_path); FreePool(dev_path); - file_size = file_read(root, dev_path_str, 0, 0, file_buffer); + file_size = file_read(root, dev_path_str, 0, 0, &file_buffer); FreePool(dev_path_str); uefi_call_wrapper(root->Close, 1, root); -- 2.47.3