From 10ae9ed5fe7f09c7edb5af266149a9b5e9bcbaa4 Mon Sep 17 00:00:00 2001 From: Antonio Quartulli Date: Thu, 24 Aug 2017 15:55:47 +0800 Subject: [PATCH] fragment.c: simplify boolean expression !A || (A && B) is equivalent to the simpler !A || B therefore it is preferable to use the second version as it is simpler to parse while reading the code. Signed-off-by: Antonio Quartulli Acked-by: David Sommerseth Message-Id: <20170824075547.29844-1-a@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15313.html Signed-off-by: David Sommerseth --- src/openvpn/fragment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/fragment.c b/src/openvpn/fragment.c index 38de62f12..84f012144 100644 --- a/src/openvpn/fragment.c +++ b/src/openvpn/fragment.c @@ -208,7 +208,7 @@ fragment_incoming(struct fragment_master *f, struct buffer *buf, } /* is this the first fragment for our sequence number? */ - if (!frag->defined || (frag->defined && frag->max_frag_size != size)) + if (!frag->defined || frag->max_frag_size != size) { frag->defined = true; frag->max_frag_size = size; -- 2.47.2