From 10ed6280ffb079944e2548e9a18c698ee969049d Mon Sep 17 00:00:00 2001 From: Jason Ish Date: Fri, 24 Jan 2025 11:18:54 -0600 Subject: [PATCH] ndpi: fix memory in keyword setup - remove duplicate calls to ndpi_init_detection_module - cleanup ndpi_init_detection_module when no longer needed --- plugins/ndpi/ndpi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/plugins/ndpi/ndpi.c b/plugins/ndpi/ndpi.c index ec0342c78a..60accf4576 100644 --- a/plugins/ndpi/ndpi.c +++ b/plugins/ndpi/ndpi.c @@ -226,7 +226,6 @@ static DetectnDPIProtocolData *DetectnDPIProtocolParse(const char *arg, bool neg if (unlikely(ndpi_struct == NULL)) return NULL; - ndpi_struct = ndpi_init_detection_module(NULL); NDPI_BITMASK_SET_ALL(all); ndpi_set_protocol_detection_bitmask2(ndpi_struct, &all); ndpi_finalize_initialization(ndpi_struct); @@ -346,10 +345,10 @@ static DetectnDPIRiskData *DetectnDPIRiskParse(const char *arg, bool negate) if (unlikely(ndpi_struct == NULL)) return NULL; - ndpi_struct = ndpi_init_detection_module(NULL); NDPI_BITMASK_SET_ALL(all); ndpi_set_protocol_detection_bitmask2(ndpi_struct, &all); ndpi_finalize_initialization(ndpi_struct); + ndpi_exit_detection_module(ndpi_struct); if (isdigit(arg[0])) risk_mask = atoll(arg); -- 2.47.2