From 12e488367d34657a5c0e1bc322e66c48463d2a0c Mon Sep 17 00:00:00 2001 From: Jiasheng Jiang Date: Fri, 1 Jul 2022 16:23:58 +0800 Subject: [PATCH] ssl/tls_srp.c: Add check for BN_dup As the potential failure of the BN_dup, it should be better to check the return value in order to guarantee the success. Signed-off-by: Jiasheng Jiang Reviewed-by: Tomas Mraz Reviewed-by: Shane Lontis Reviewed-by: Todd Short (Merged from https://github.com/openssl/openssl/pull/18699) --- ssl/tls_srp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ssl/tls_srp.c b/ssl/tls_srp.c index e69ddfe9d58..a4ec363cfba 100644 --- a/ssl/tls_srp.c +++ b/ssl/tls_srp.c @@ -238,7 +238,7 @@ int SSL_set_srp_server_param_pw(SSL *s, const char *user, const char *pass, BN_clear_free(s->srp_ctx.s); s->srp_ctx.s = NULL; if (!SRP_create_verifier_BN_ex(user, pass, &s->srp_ctx.s, &s->srp_ctx.v, - GN->N, GN->g, s->ctx->libctx, + s->srp_ctx.N, s->srp_ctx.g, s->ctx->libctx, s->ctx->propq)) return -1; -- 2.47.2