From 138774b234457bde1af522062be74403d71ea7d9 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Wed, 6 Jul 2011 12:07:36 -0400 Subject: [PATCH] - fix up the invalidate on connect for py3k - fix the test for separately installed pysqlite --- lib/sqlalchemy/engine/strategies.py | 8 ++++++-- test/engine/test_parseconnect.py | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/sqlalchemy/engine/strategies.py b/lib/sqlalchemy/engine/strategies.py index 528bc31757..b9a1671ec8 100644 --- a/lib/sqlalchemy/engine/strategies.py +++ b/lib/sqlalchemy/engine/strategies.py @@ -81,12 +81,16 @@ class DefaultEngineStrategy(EngineStrategy): except Exception, e: # Py3K #raise exc.DBAPIError.instance(None, None, - # e, dialect.dbapi.Error) from e + # e, dialect.dbapi.Error, + # connection_invalidated= + # dialect.is_disconnect(e, None, None) + # ) from e # Py2K import sys raise exc.DBAPIError.instance( None, None, e, dialect.dbapi.Error, - connection_invalidated=dialect.is_disconnect(e, None, None)), \ + connection_invalidated= + dialect.is_disconnect(e, None, None)), \ None, sys.exc_info()[2] # end Py2K diff --git a/test/engine/test_parseconnect.py b/test/engine/test_parseconnect.py index 1c1ab6aad1..ef15cde9fe 100644 --- a/test/engine/test_parseconnect.py +++ b/test/engine/test_parseconnect.py @@ -232,7 +232,8 @@ pool_timeout=10 # "Cannot operate on a closed database." error # on connect. IRL we'd be getting Oracle's "shutdown in progress" - import sqlite3 + e = create_engine('sqlite://') + sqlite3 = e.dialect.dbapi class ThrowOnConnect(MockDBAPI): dbapi = sqlite3 Error = sqlite3.Error -- 2.39.5