From 13bf7812ef512d86d026ada34e75b22692152441 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 16 Jul 2025 17:17:34 -0700 Subject: [PATCH] x86-64: Compile ISA versions of modf/modff with -fno-stack-protector Since modf and modff are compiled into both libc and libm, when glibc is configured with --enable-stack-protector=all, ISA versions of modf and modff should be compiled with -fno-stack-protector to avoid calling __stack_chk_fail via PLT in libc.so. This fixes BZ #33165. Signed-off-by: H.J. Lu Reviewed-by: Andreas K. Huettel --- sysdeps/x86_64/fpu/multiarch/Makefile | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/sysdeps/x86_64/fpu/multiarch/Makefile b/sysdeps/x86_64/fpu/multiarch/Makefile index 5fe872b898..81a870d3b1 100644 --- a/sysdeps/x86_64/fpu/multiarch/Makefile +++ b/sysdeps/x86_64/fpu/multiarch/Makefile @@ -159,11 +159,18 @@ CFLAGS-s_sin-avx.c = -msse2avx -DSSE2AVX CFLAGS-s_tan-avx.c = -msse2avx -DSSE2AVX CFLAGS-s_sincos-avx.c = -msse2avx -DSSE2AVX -CFLAGS-s_modf-sse4_1.c = -msse4.1 -fno-builtin-modff32x -fno-builtin-modff64 -CFLAGS-s_modff-sse4_1.c = -msse4.1 -fno-builtin-modff32 +CFLAGS-s_modf-c.c = $(no-stack-protector) +CFLAGS-s_modff-c.c = $(no-stack-protector) -CFLAGS-s_modf-avx.c = -msse2avx -DSSE2AVX -fno-builtin-modff32x -fno-builtin-modff64 -CFLAGS-s_modff-avx.c = -msse2avx -DSSE2AVX -fno-builtin-modff32 +CFLAGS-s_modf-sse4_1.c = -msse4.1 -fno-builtin-modff32x \ + -fno-builtin-modff64 $(no-stack-protector) +CFLAGS-s_modff-sse4_1.c = -msse4.1 -fno-builtin-modff32 \ + $(no-stack-protector) + +CFLAGS-s_modf-avx.c = -msse2avx -DSSE2AVX -fno-builtin-modff32x \ + $(no-stack-protector) -fno-builtin-modff64 +CFLAGS-s_modff-avx.c = -msse2avx -DSSE2AVX -fno-builtin-modff32 \ + $(no-stack-protector) endif ifeq ($(subdir),mathvec) -- 2.47.2