From 14021d369a0eca3b9a669dd317839a909040b81f Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat, 11 Apr 2020 05:46:33 -0700 Subject: [PATCH] Remove unused layouts.defaults (#7264) * Remove unused layouts.defaults * Add to migration guide --- docs/getting-started/v3-migration.md | 4 ++++ src/core/core.layouts.js | 1 - test/specs/core.layouts.tests.js | 1 - 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/getting-started/v3-migration.md b/docs/getting-started/v3-migration.md index dddab3924..b030404be 100644 --- a/docs/getting-started/v3-migration.md +++ b/docs/getting-started/v3-migration.md @@ -221,6 +221,10 @@ The following properties and methods were removed: * `helpers.scaleMerge` * `helpers.where` +#### Layout + +* `Layout.defaults` + #### Scales * `LogarithmicScale.minNotZero` diff --git a/src/core/core.layouts.js b/src/core/core.layouts.js index d1261d63f..585bedd67 100644 --- a/src/core/core.layouts.js +++ b/src/core/core.layouts.js @@ -230,7 +230,6 @@ defaults.set('layout', { // Scales, Legends and Plugins all rely on the layout service and can easily register to be placed anywhere they need // It is this service's responsibility of carrying out that layout. export default { - defaults: {}, /** * Register a box to a chart. diff --git a/test/specs/core.layouts.tests.js b/test/specs/core.layouts.tests.js index 6c161b6c6..7efceaa18 100644 --- a/test/specs/core.layouts.tests.js +++ b/test/specs/core.layouts.tests.js @@ -6,7 +6,6 @@ describe('Chart.layouts', function() { it('should be exposed through Chart.layouts', function() { expect(Chart.layouts).toBeDefined(); expect(typeof Chart.layouts).toBe('object'); - expect(Chart.layouts.defaults).toBeDefined(); expect(Chart.layouts.addBox).toBeDefined(); expect(Chart.layouts.removeBox).toBeDefined(); expect(Chart.layouts.configure).toBeDefined(); -- 2.47.2