From 15461b7f19272d39e59e4c6d87dfe9d48f4d1f99 Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Fri, 6 Oct 2023 12:08:42 +0100 Subject: [PATCH] core: improve debug logs when failing to create symlinks in namespaces I am seeing some failures and I don't know what is failing and why even with debug logs, so add more details --- src/core/namespace.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/core/namespace.c b/src/core/namespace.c index feedb283cdb..ffb1bb18874 100644 --- a/src/core/namespace.c +++ b/src/core/namespace.c @@ -1828,11 +1828,18 @@ static int create_symlinks_from_tuples(const char *root, char **strv_symlinks) { r = mkdir_parents_label(dst_abs, 0755); if (r < 0) - return r; + return log_debug_errno( + r, + "Failed to create parent directory for symlink '%s': %m", + dst_abs); r = symlink_idempotent(src_abs, dst_abs, true); if (r < 0) - return r; + return log_debug_errno( + r, + "Failed to create symlink from '%s' to '%s': %m", + src_abs, + dst_abs); } return 0; -- 2.47.3