From 159652d9378ac418e25fc44f40bb4dc0cdc9ced3 Mon Sep 17 00:00:00 2001 From: Ruediger Meier Date: Fri, 8 May 2015 13:39:53 +0200 Subject: [PATCH] libfdisk: (gpt) fix attributes endianess The new libfdisk/gpt test (4a4a0927) discovered that we read and write partition attributes wrongly on BE systems. Our temporarily used char[8] bits are always LE and do not need to be converted. CC: Michael Marineau Signed-off-by: Ruediger Meier --- libfdisk/src/gpt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libfdisk/src/gpt.c b/libfdisk/src/gpt.c index a7ec5397a4..3db81bedfb 100644 --- a/libfdisk/src/gpt.c +++ b/libfdisk/src/gpt.c @@ -1415,7 +1415,7 @@ static int gpt_entry_attrs_to_string(struct gpt_entry *e, char **res) assert(res); *res = NULL; - attrs = le64_to_cpu(e->attrs); + attrs = e->attrs; if (!attrs) return 0; /* no attributes at all */ @@ -1530,7 +1530,7 @@ static int gpt_entry_attrs_from_string( p++; } - e->attrs = cpu_to_le64(attrs); + e->attrs = attrs; return 0; } @@ -2517,7 +2517,7 @@ static int gpt_toggle_partition_flag( if ((uint32_t) i >= le32_to_cpu(gpt->pheader->npartition_entries)) return -EINVAL; - attrs = le64_to_cpu(gpt->ents[i].attrs); + attrs = gpt->ents[i].attrs; bits = (char *) &attrs; switch (flag) { @@ -2558,7 +2558,7 @@ static int gpt_toggle_partition_flag( else clrbit(bits, bit); - gpt->ents[i].attrs = cpu_to_le64(attrs); + gpt->ents[i].attrs = attrs; if (flag == GPT_FLAG_GUIDSPECIFIC) fdisk_info(cxt, isset(bits, bit) ? -- 2.47.3