From 15d93bd860aff8bbc1b2f4603a700cf8677e4c06 Mon Sep 17 00:00:00 2001 From: Florian Krohm Date: Tue, 4 Oct 2011 03:55:04 +0000 Subject: [PATCH] Fix execve2 testcase. First, due to a typo in Makefile.am it was compiled with the wrong flags. Secondly, the testcase gives an incorrect backtrace on x86 (missing the line where the error occurs). Updated the generic exp to contain the correct result and added exp-kfail for platforms where this test fails. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@12094 --- memcheck/tests/Makefile.am | 2 +- memcheck/tests/execve2.stderr.exp | 1 + memcheck/tests/execve2.stderr.exp-kfail | 4 ++++ 3 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 memcheck/tests/execve2.stderr.exp-kfail diff --git a/memcheck/tests/Makefile.am b/memcheck/tests/Makefile.am index 2c44fcfa26..a8a61805e3 100644 --- a/memcheck/tests/Makefile.am +++ b/memcheck/tests/Makefile.am @@ -288,7 +288,7 @@ error_counts_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ execve1_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@ -execve2_CFLAGS = $(AM_CFLASG) @FLAG_W_NO_NONNULL@ +execve2_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@ inits_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ diff --git a/memcheck/tests/execve2.stderr.exp b/memcheck/tests/execve2.stderr.exp index 9e86cbdf84..b87bff8f44 100644 --- a/memcheck/tests/execve2.stderr.exp +++ b/memcheck/tests/execve2.stderr.exp @@ -1,4 +1,5 @@ Syscall param execve(filename) points to unaddressable byte(s) ... + by 0x........: main (execve2.c:8) Address 0x........ is not stack'd, malloc'd or (recently) free'd diff --git a/memcheck/tests/execve2.stderr.exp-kfail b/memcheck/tests/execve2.stderr.exp-kfail new file mode 100644 index 0000000000..9e86cbdf84 --- /dev/null +++ b/memcheck/tests/execve2.stderr.exp-kfail @@ -0,0 +1,4 @@ +Syscall param execve(filename) points to unaddressable byte(s) + ... + Address 0x........ is not stack'd, malloc'd or (recently) free'd + -- 2.47.2