From 164570fcbbee16a7b42a0adb49c471f198b54a39 Mon Sep 17 00:00:00 2001 From: Noel Power Date: Fri, 14 Jun 2019 13:57:59 +0000 Subject: [PATCH] lib/param: clang: Fix 'dereference of a null pointer' warning Fixes: lib/param/loadparm.c:3325:36: warning: Access to field 'szService' results in a dereference of a null pointer (loaded from variable 'service') <--[clang] return lpcfg_string((const char *)service->szService) Signed-off-by: Noel Power Reviewed-by: Gary Lockyer Autobuild-User(master): Noel Power Autobuild-Date(master): Wed Jun 26 11:53:08 UTC 2019 on sn-devel-184 --- lib/param/loadparm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c index e03c1556d7e..169d884ec04 100644 --- a/lib/param/loadparm.c +++ b/lib/param/loadparm.c @@ -3322,7 +3322,7 @@ struct loadparm_service *lpcfg_service(struct loadparm_context *lp_ctx, const char *lpcfg_servicename(const struct loadparm_service *service) { - return lpcfg_string((const char *)service->szService); + return service ? lpcfg_string((const char *)service->szService) : NULL; } /** -- 2.47.2