From 1652babf15cea63323411c450c408848f96e5866 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 18 Jan 2022 16:59:35 +0100 Subject: [PATCH] qemuValidateDomainDeviceDefVideo: Reject non-default video head count for devices not supporting it MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Only QXL and virtio-vga actually propagate the 'heads' attribute as 'max_outputs' to the commandline of qemu. Reject the setting when non-default value is used for any other video type. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2036300 Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_validate.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index b5783e84ad..ae0ee4e744 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2480,6 +2480,13 @@ qemuValidateDomainDeviceDefVideo(const virDomainVideoDef *video, virDomainVideoTypeToString(video->type)); return -1; } + + if (video->heads != 1) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("video type '%s' doesn't support multiple 'heads'"), + virDomainVideoTypeToString(video->type)); + return -1; + } } if (video->accel && video->accel->accel2d == VIR_TRISTATE_SWITCH_ON) { -- 2.47.2