From 1896b100af4659d9fee183a91ff4929baa4c7be4 Mon Sep 17 00:00:00 2001 From: Jakub Kicinski Date: Tue, 5 Nov 2019 13:17:06 -0800 Subject: [PATCH] devlink: catch missing strings in dl_args_required Currently if dl_args_required doesn't contain a string for a given option the fact that the option is missing is silently ignored. Add a catch-all case and print a generic error. Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko Signed-off-by: David Ahern --- devlink/devlink.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/devlink/devlink.c b/devlink/devlink.c index 682f832a0..e05a23367 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -1157,6 +1157,10 @@ static int dl_args_finding_required_validate(uint64_t o_required, return -EINVAL; } } + if (o_required & ~o_found) { + pr_err("BUG: unknown argument required but not found\n"); + return -EINVAL; + } return 0; } -- 2.47.2