From 18dbcae25a421c39030b050de4d42d76d715d512 Mon Sep 17 00:00:00 2001 From: Nikolay Nechaev Date: Sun, 20 Jun 2021 17:54:01 +0300 Subject: [PATCH] maint: remove redundant checks on buffer sizes in tail * src/tail.c: remove redundant size checks before calls to `xwrite_stdout` --- src/tail.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/tail.c b/src/tail.c index ff567560dc..b91fcfd82c 100644 --- a/src/tail.c +++ b/src/tail.c @@ -579,8 +579,7 @@ file_lines (char const *pretty_filename, int fd, uintmax_t n_lines, { /* If this newline isn't the last character in the buffer, output the part that is after it. */ - if (n != bytes_read - 1) - xwrite_stdout (nl + 1, bytes_read - (n + 1)); + xwrite_stdout (nl + 1, bytes_read - (n + 1)); *read_pos += dump_remainder (false, pretty_filename, fd, end_pos - (pos + bytes_read)); return true; @@ -881,8 +880,8 @@ start_bytes (char const *pretty_filename, int fd, uintmax_t n_bytes, else { size_t n_remaining = bytes_read - n_bytes; - if (n_remaining) - xwrite_stdout (&buffer[n_bytes], n_remaining); + // Print extra characters if there are any + xwrite_stdout (&buffer[n_bytes], n_remaining); break; } } -- 2.47.2