From 1a35da04d1f84c5a162ba3fd7aa5469c4b7c34fd Mon Sep 17 00:00:00 2001 From: Maria Matejka Date: Thu, 13 Feb 2025 18:25:44 +0100 Subject: [PATCH] Taming static checker: flow[64]_validate_cf() checks NULL data This does not apply for the current code but if somebody chose to use the flowspec validation functions for something totally broken, it may unnecessarily crash. --- lib/flowspec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/flowspec.c b/lib/flowspec.c index eaaffb148..a20cc6d2c 100644 --- a/lib/flowspec.c +++ b/lib/flowspec.c @@ -609,6 +609,7 @@ flow6_validate(const byte *nlri, uint len) void flow4_validate_cf(net_addr_flow4 *f) { + ASSERT_DIE(f && f->data); enum flow_validated_state r = flow4_validate(flow4_first_part(f), flow_read_length(f->data)); if (r != FLOW_ST_VALID) @@ -625,6 +626,7 @@ flow4_validate_cf(net_addr_flow4 *f) void flow6_validate_cf(net_addr_flow6 *f) { + ASSERT_DIE(f && f->data); enum flow_validated_state r = flow6_validate(flow6_first_part(f), flow_read_length(f->data)); if (r != FLOW_ST_VALID) -- 2.47.2