From 1a51ec16db7aa1688d0083911db78e17ff7f26ba Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 16 Apr 2026 09:53:03 +0200 Subject: [PATCH] MSVC: Turn missing function declaration into an error Calling an undeclared function should be an error as of C99, and GCC and Clang do that, but MSVC doesn't even warn about it in the default warning level. (Commit c86d2ccdb35 fixed an instance of this problem.) This turns on this warning and makes it an error by default, to match other compilers. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/1142ad86-e475-41b3-aeee-c6ad913064fa%40eisentraut.org --- meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meson.build b/meson.build index be97e986e5d..7f82876dbc8 100644 --- a/meson.build +++ b/meson.build @@ -2330,6 +2330,9 @@ if cc.get_id() == 'msvc' # Additional warnings to enable: '/w24062', # enumerator 'identifier' in switch of enum 'enumeration' is not handled [like -Wswitch] '/w24102', # unreferenced label [like -Wunused-label] + + # Turn this into an error, to match other compilers (as of C99) + '/we4013', # 'function' undefined; assuming extern returning int' [like -Wimplicit-function-declaration] ] msvc_c_warning_flags = [ -- 2.47.3