From 1aa1facabc26b8cc6da3acec5e960983b72f5f2c Mon Sep 17 00:00:00 2001 From: "W.C.A. Wijngaards" Date: Mon, 24 Jun 2019 10:53:27 +0200 Subject: [PATCH] - Fix memleak in unit test, reported from the clang 8.0 static analyzer. --- doc/Changelog | 3 +++ testcode/memstats.c | 11 +++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/doc/Changelog b/doc/Changelog index 2cb6d0124..a5df4d555 100644 --- a/doc/Changelog +++ b/doc/Changelog @@ -1,3 +1,6 @@ +24 June 2019: Wouter + - Fix memleak in unit test, reported from the clang 8.0 static analyzer. + 18 June 2019: Wouter - PR #28: IPSet module, by Kevin Chou. Created a module to support the ipset that could add the domain's ip to a list easily. diff --git a/testcode/memstats.c b/testcode/memstats.c index dc29058ad..a253b00ac 100644 --- a/testcode/memstats.c +++ b/testcode/memstats.c @@ -106,9 +106,16 @@ get_codeline(rbtree_type* tree, char* key, char* func) cl = calloc(1, sizeof(*cl)); if(!cl) return 0; cl->codeline = strdup(key); - if(!cl->codeline) return 0; + if(!cl->codeline) { + free(cl); + return 0; + } cl->func = strdup(func); - if(!cl->func) return 0; + if(!cl->func) { + free(cl->codeline); + free(cl); + return 0; + } cl->alloc = 0; cl->node.key = cl->codeline; (void)rbtree_insert(tree, &cl->node); -- 2.47.3