From 1aa21d6c316162bb1a5568cf7f3639aab2ff5ea3 Mon Sep 17 00:00:00 2001 From: "jocuri%softhome.net" <> Date: Thu, 9 Dec 2004 17:22:20 +0000 Subject: [PATCH] Patch for bug 233049: Improve error when filtering requests with component not in the selected product; patch by Marc Schumann , r=vladd, a=justdave. --- request.cgi | 5 +++-- template/en/default/global/code-error.html.tmpl | 8 -------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/request.cgi b/request.cgi index 445783d471..f872d1d286 100755 --- a/request.cgi +++ b/request.cgi @@ -170,10 +170,11 @@ sub queue { push(@criteria, "bugs.component_id = $component_id"); push(@excluded_columns, 'component') unless $cgi->param('do_union'); } - else { ThrowCodeError("unknown_component", { component => $cgi->param('component') }) } + else { ThrowUserError("component_not_valid", { 'product' => $cgi->param('product'), + 'name' => $cgi->param('component') }) } } } - else { ThrowCodeError("unknown_product", { product => $cgi->param('product') }) } + else { ThrowUserError("product_doesnt_exist", { 'product' => $cgi->param('product') }) } } # Filter results by flag types. diff --git a/template/en/default/global/code-error.html.tmpl b/template/en/default/global/code-error.html.tmpl index ae47ed3495..8959437a6e 100644 --- a/template/en/default/global/code-error.html.tmpl +++ b/template/en/default/global/code-error.html.tmpl @@ -235,14 +235,6 @@ I could not figure out what you wanted to do. [% END %] - [% ELSIF error == "unknown_component" %] - [% title = "Unknown Component" %] - There is no component named [% component FILTER html %]. - - [% ELSIF error == "unknown_product" %] - [% title = "Unknown Product" %] - There is no product named [% product FILTER html %]. - [% ELSE %] [% title = "Internal error" %] An internal error has occured, but [% terms.Bugzilla %] doesn't know -- 2.47.2