From 1b38b46ab7c88d79e89e31cf8d22cd346c97d3ae Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Sun, 3 Dec 2017 19:02:28 +0100 Subject: [PATCH] BUG/MINOR: h2: do not accept SETTINGS_ENABLE_PUSH other than 0 or 1 We don't use yet it but for correctness, let's enforce the check. To backport to 1.8. --- src/mux_h2.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/mux_h2.c b/src/mux_h2.c index 28c5eb7060..771a3e6022 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -1102,6 +1102,12 @@ static int h2c_handle_settings(struct h2c *h2c) } h2c->mfs = arg; break; + case H2_SETTINGS_ENABLE_PUSH: + if (arg < 0 || arg > 1) { // RFC7540#6.5.2 + error = H2_ERR_PROTOCOL_ERROR; + goto fail; + } + break; } } -- 2.47.2