From 1b5db4e308443227ed5b97d8e5c287c6fc34eb4b Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Thu, 19 Mar 2026 01:59:04 +0200 Subject: [PATCH] media: renesas: vsp1: histo: Fix size enumeration The histogram supports size enumeration on the sink pad only, as the source pad outputs a metadata format. The correct error code when enumeration is not supported is -ENOTTY, not -EINVAL. Fix it. Tested-by: Lad Prabhakar # HiHope RZ/G2M Link: https://patch.msgid.link/20260318235907.831556-11-laurent.pinchart+renesas@ideasonboard.com Signed-off-by: Laurent Pinchart Signed-off-by: Hans Verkuil --- drivers/media/platform/renesas/vsp1/vsp1_histo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/renesas/vsp1/vsp1_histo.c b/drivers/media/platform/renesas/vsp1/vsp1_histo.c index f97aecb220581..313b9f3ce0f16 100644 --- a/drivers/media/platform/renesas/vsp1/vsp1_histo.c +++ b/drivers/media/platform/renesas/vsp1/vsp1_histo.c @@ -183,7 +183,7 @@ static int histo_enum_frame_size(struct v4l2_subdev *subdev, struct v4l2_subdev_frame_size_enum *fse) { if (fse->pad != HISTO_PAD_SINK) - return -EINVAL; + return -ENOTTY; return vsp1_subdev_enum_frame_size(subdev, sd_state, fse); } -- 2.47.3