From 1b75e8c5fa061a45698fc9ca96a2581795a73881 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A1n=20Tomko?= Date: Fri, 23 Feb 2018 14:52:24 +0100 Subject: [PATCH] vboxDumpNetwork: use VIR_STEAL_PTR instead of VIR_STRDUP MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit We can steal the strings instead of creating more copies. Signed-off-by: Ján Tomko --- src/vbox/vbox_common.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 8f5f04efb3..1a413e4aca 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -3719,9 +3719,7 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *adapter) gVBoxAPI.UINetworkAdapter.GetBridgedInterface(adapter, &utf16); VBOX_UTF16_TO_UTF8(utf16, &utf8); - ignore_value(VIR_STRDUP(net->data.bridge.brname, utf8)); - - VBOX_UTF8_FREE(utf8); + VIR_STEAL_PTR(net->data.bridge.brname, utf8); VBOX_UTF16_FREE(utf16); break; @@ -3731,9 +3729,7 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *adapter) gVBoxAPI.UINetworkAdapter.GetInternalNetwork(adapter, &utf16); VBOX_UTF16_TO_UTF8(utf16, &utf8); - ignore_value(VIR_STRDUP(net->data.internal.name, utf8)); - - VBOX_UTF8_FREE(utf8); + VIR_STEAL_PTR(net->data.internal.name, utf8); VBOX_UTF16_FREE(utf16); break; @@ -3743,9 +3739,7 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *adapter) gVBoxAPI.UINetworkAdapter.GetHostOnlyInterface(adapter, &utf16); VBOX_UTF16_TO_UTF8(utf16, &utf8); - ignore_value(VIR_STRDUP(net->data.network.name, utf8)); - - VBOX_UTF8_FREE(utf8); + VIR_STEAL_PTR(net->data.network.name, utf8); VBOX_UTF16_FREE(utf16); break; -- 2.47.2