From 1c7601f5c37d0441396fb9a66af2400781213e0c Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A1n=20Tomko?= Date: Mon, 30 Jun 2014 15:00:33 +0200 Subject: [PATCH] Report one error less when getting net dev speed virFileReadAll already logs an error. If reading the 'speed' file fails with EINVAL, we log an error even though we ignore it. If it fails with other errors, we log two errors. Use virFileReadAllQuiet - ignore EINVAL and report just one error in other cases. Fixes this error on libvirtd startup: 2014-06-30 12:47:14.583+0000: 20971: error : virFileReadAll:1297 : Failed to read file '/sys/class/net/wlan0/speed': Invalid argument --- src/util/virnetdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index a551f9820b..fc9ec1e4b8 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1891,7 +1891,7 @@ virNetDevGetLinkInfo(const char *ifname, if (virNetDevSysfsFile(&path, ifname, "speed") < 0) goto cleanup; - if (virFileReadAll(path, 1024, &buf) < 0) { + if (virFileReadAllQuiet(path, 1024, &buf) < 0) { /* Some devices doesn't report speed, in which case we get EINVAL */ if (errno == EINVAL) { ret = 0; -- 2.47.2