From 1cf7e6ec057a80f3c256d739a8228e04b7fb8862 Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Wed, 25 Jan 2023 15:25:06 +0100 Subject: [PATCH] remote: Drop useless cleanup in remoteDispatchNodeGet{CPU,Memory}Stats The function cannot fail once it starts populating ret->params.params_val[i].field. Signed-off-by: Jiri Denemark Reviewed-by: Michal Privoznik --- src/remote/remote_daemon_dispatch.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c index 54afa5c2f4..250eb51e6b 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -3310,11 +3310,6 @@ remoteDispatchNodeGetCPUStats(virNetServer *server G_GNUC_UNUSED, cleanup: if (rv < 0) { virNetMessageSaveError(rerr); - if (ret->params.params_val) { - for (i = 0; i < nparams; i++) - VIR_FREE(ret->params.params_val[i].field); - VIR_FREE(ret->params.params_val); - } } VIR_FREE(params); return rv; @@ -3377,11 +3372,6 @@ remoteDispatchNodeGetMemoryStats(virNetServer *server G_GNUC_UNUSED, cleanup: if (rv < 0) { virNetMessageSaveError(rerr); - if (ret->params.params_val) { - for (i = 0; i < nparams; i++) - VIR_FREE(ret->params.params_val[i].field); - VIR_FREE(ret->params.params_val); - } } VIR_FREE(params); return rv; -- 2.47.2