From 1cf99ce3f79b2c96bdef5aa9b69c2b3ead7e46f1 Mon Sep 17 00:00:00 2001 From: Konrad Weihmann Date: Sat, 1 Jun 2024 08:07:03 +0000 Subject: [PATCH] insane: error out on UNPACKDIR = WORKDIR as this will clear WORKDIR and create race conditions across various handling tasks Signed-off-by: Konrad Weihmann Signed-off-by: Richard Purdie --- meta/classes-global/insane.bbclass | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 822d190a304..bd05da0378e 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -1596,10 +1596,13 @@ python () { sourcedir = d.getVar("S") builddir = d.getVar("B") workdir = d.getVar("WORKDIR") + unpackdir = d.getVar("UNPACKDIR") if sourcedir == workdir: bb.fatal("Using S = ${WORKDIR} is no longer supported") if builddir == workdir: bb.fatal("Using B = ${WORKDIR} is no longer supported") + if unpackdir == workdir: + bb.fatal("Using UNPACKDIR = ${WORKDIR} is not supported") if sourcedir[-1] == '/': bb.warn("Recipe %s sets S variable with trailing slash '%s', remove it" % (d.getVar("PN"), d.getVar("S"))) if builddir[-1] == '/': -- 2.47.2