From 1d058a292c517de63ba29b1ea20ef7819f5a302e Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Wed, 21 Mar 2012 12:38:34 -0400 Subject: [PATCH] Don't allow CREATE TABLE AS to put relations in pg_global. This was never intended to be allowed, and is blocked for an ordinary CREATE TABLE, but CREATE TABLE AS slipped through the cracks. This commit won't do anything to fix existing cases where this has loophole has been exploited, but it still seems prudent to lock it down going forward. Back-branch commit only, as this problem has been refactored away on the master branch. Andres Freund --- src/backend/executor/execMain.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index aa64ae7a670..53df597552a 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -39,6 +39,7 @@ #include "access/xact.h" #include "catalog/heap.h" #include "catalog/namespace.h" +#include "catalog/pg_tablespace.h" #include "catalog/toasting.h" #include "commands/tablespace.h" #include "commands/trigger.h" @@ -2940,6 +2941,12 @@ OpenIntoRel(QueryDesc *queryDesc) get_tablespace_name(tablespaceId)); } + /* In all cases disallow placing user relations in pg_global */ + if (tablespaceId == GLOBALTABLESPACE_OID) + ereport(ERROR, + (errcode(ERRCODE_INVALID_PARAMETER_VALUE), + errmsg("only shared relations can be placed in pg_global tablespace"))); + /* Parse and validate any reloptions */ reloptions = transformRelOptions((Datum) 0, into->options, -- 2.39.5