From 1d830152d59a8279bec1b9ddaf2a7e2ca3ef4d8b Mon Sep 17 00:00:00 2001
From: Axel Viala <axel.viala@darnuria.eu>
Date: Thu, 6 Oct 2022 13:48:58 +0200
Subject: [PATCH] [clang-tidy:empty] use empty() in various places.

- dnsrecords.cc
- recursor_cache.cc
- dnsrecords.cc.
- zoneparser-tng.cc

empty
---
 pdns/dnsparser.cc      | 2 +-
 pdns/dnsrecords.cc     | 4 ++--
 pdns/zoneparser-tng.cc | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/pdns/dnsparser.cc b/pdns/dnsparser.cc
index 1da2232422..19edfa42fa 100644
--- a/pdns/dnsparser.cc
+++ b/pdns/dnsparser.cc
@@ -108,7 +108,7 @@ shared_ptr<DNSRecordContent> DNSRecordContent::deserialize(const DNSName& qname,
   drh.d_clen=htons(serialized.size());
 
   memcpy(&packet[pos], &drh, sizeof(drh)); pos+=sizeof(drh);
-  if (serialized.size() > 0) {
+  if (!serialized.empty()) {
     memcpy(&packet[pos], serialized.c_str(), serialized.size());
     pos += (uint16_t) serialized.size();
     (void) pos;
diff --git a/pdns/dnsrecords.cc b/pdns/dnsrecords.cc
index 66e29f1a07..c70e6fc5be 100644
--- a/pdns/dnsrecords.cc
+++ b/pdns/dnsrecords.cc
@@ -55,7 +55,7 @@ string DNSResourceRecord::getZoneRepresentation(bool noDot) const {
     case QType::SRV:
     case QType::MX:
       stringtok(parts, content);
-      if (!parts.size())
+      if (parts.empty())
         return "";
       last = *parts.rbegin();
       ret << content;
@@ -780,7 +780,7 @@ void SVCBBaseRecordContent::removeParam(const SvcParam::SvcParamKey &key) {
 }
 
 bool SVCBBaseRecordContent::hasParams() const {
-  return d_params.size() > 0;
+  return !d_params.empty();
 }
 
 bool SVCBBaseRecordContent::hasParam(const SvcParam::SvcParamKey &key) const {
diff --git a/pdns/zoneparser-tng.cc b/pdns/zoneparser-tng.cc
index f3cdbcb5b9..12951790a1 100644
--- a/pdns/zoneparser-tng.cc
+++ b/pdns/zoneparser-tng.cc
@@ -311,7 +311,7 @@ DNSName ZoneParserTNG::getZoneName()
 
 string ZoneParserTNG::getLineOfFile()
 {
-  if (d_zonedata.size() > 0)
+  if (!d_zonedata.empty())
     return "on line "+std::to_string(std::distance(d_zonedata.begin(), d_zonedataline))+" of given string";
 
   if (d_filestates.empty())
@@ -658,7 +658,7 @@ bool ZoneParserTNG::get(DNSResourceRecord& rr, std::string* comment)
 
 bool ZoneParserTNG::getLine()
 {
-  if (d_zonedata.size() > 0) {
+  if (!d_zonedata.empty()) {
     if (d_zonedataline != d_zonedata.end()) {
       d_line = *d_zonedataline;
       ++d_zonedataline;
-- 
2.47.2