From 1fa857c2d033512c429659d89d10a554c81f7791 Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Thu, 11 Mar 2010 00:57:17 +1300 Subject: [PATCH] Author: Henrik Nordstrom Bug 2367: Fix stale=true on digest requests with unknown nonce The nonce staleness check only worked if the stale nonce had not yet been garbage collected, often resulting in incorrect stale=false responses and resulting auth popups when using digest auth. Note: this fix is different from how it's done in squid-2 where fixHeader is called on all schemes in such conditions but only the active one with and auth_user_request. Not entirely sure why that is done, but commit message says something about Negotiate authentication. --- src/auth/digest/auth_digest.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/auth/digest/auth_digest.cc b/src/auth/digest/auth_digest.cc index 784cc5ef82..cff25b63ae 100644 --- a/src/auth/digest/auth_digest.cc +++ b/src/auth/digest/auth_digest.cc @@ -1309,6 +1309,7 @@ AuthDigestConfig::decode(char const *proxy_auth) if (!nonce) { /* we couldn't find a matching nonce! */ debugs(29, 2, "authenticateDigestDecode: Unexpected or invalid nonce received"); + digest_request->credentials(AuthDigestUserRequest::Failed); return authDigestLogUsername(username, digest_request); } -- 2.47.2