From 20bcda681f8597e86070a4b3b12d1e4f541865d3 Mon Sep 17 00:00:00 2001 From: Srinivas Kandagatla Date: Wed, 29 Oct 2025 14:43:35 +0000 Subject: [PATCH] ASoC: codecs: va-macro: fix revision checking The revision rework patch seems to have reversed the bit positions for macro presence in core_id_1 register. This broken RB1 and Arduino UnoQ audio. Fix these bit positions to correctly reflect the register definition. Fixes: 281c97376cfc ("ASoC: codecs: va-macro: Rework version checking") Signed-off-by: Srinivas Kandagatla Link: https://patch.msgid.link/20251029144336.356816-1-srinivas.kandagatla@oss.qualcomm.com Signed-off-by: Mark Brown --- sound/soc/codecs/lpass-va-macro.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c index 2b0ecc52c6be6..fbe5ebeeaa805 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -67,10 +67,10 @@ #define CDC_VA_TOP_CSR_CORE_ID_0 (0x00C0) #define CORE_ID_0_REV_MAJ GENMASK(7, 0) #define CDC_VA_TOP_CSR_CORE_ID_1 (0x00C4) -#define CORE_ID_1_HAS_WSAMACRO BIT(3) -#define CORE_ID_1_HAS_RXMACRO BIT(2) -#define CORE_ID_1_HAS_TXMACRO BIT(1) -#define CORE_ID_1_HAS_VAMACRO BIT(0) +#define CORE_ID_1_HAS_WSAMACRO BIT(0) +#define CORE_ID_1_HAS_RXMACRO BIT(1) +#define CORE_ID_1_HAS_TXMACRO BIT(2) +#define CORE_ID_1_HAS_VAMACRO BIT(3) #define CDC_VA_TOP_CSR_CORE_ID_2 (0x00C8) #define CORE_ID_2_REV_MIN GENMASK(7, 4) #define CORE_ID_2_REV_STEP GENMASK(3, 0) -- 2.47.3