From 215167d8d38a381d27c8448f5c6e50c70b9ba0cc Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Tue, 12 Jan 2016 09:53:09 -0500 Subject: [PATCH] - changelog for pr bitbucket:70, fixes #3624 --- doc/build/changelog/changelog_10.rst | 9 +++++++++ test/dialect/mssql/test_types.py | 12 ++++++++++++ 2 files changed, 21 insertions(+) diff --git a/doc/build/changelog/changelog_10.rst b/doc/build/changelog/changelog_10.rst index 4d017cfb15..c465c73ed1 100644 --- a/doc/build/changelog/changelog_10.rst +++ b/doc/build/changelog/changelog_10.rst @@ -19,6 +19,15 @@ :version: 1.0.12 :released: + .. change:: + :tags: bug, mssql + :tickets: 3624 + :pullreq: bitbucket:70 + + Fixed the syntax of the :func:`.extract` function when used on + MSSQL against a datetime value; the quotes around the keyword + are removed. Pull request courtesy Guillaume Doumenc. + .. change:: :tags: bug, orm :tickets: 3623 diff --git a/test/dialect/mssql/test_types.py b/test/dialect/mssql/test_types.py index dad86c60a7..100e4e0edb 100644 --- a/test/dialect/mssql/test_types.py +++ b/test/dialect/mssql/test_types.py @@ -64,6 +64,18 @@ class MSDateTypeTest(fixtures.TestBase): result_processor, 'abc' ) + def test_extract(self): + from sqlalchemy import extract + fivedaysago = datetime.datetime.now() \ + - datetime.timedelta(days=5) + for field, exp in ('year', fivedaysago.year), \ + ('month', fivedaysago.month), ('day', fivedaysago.day): + r = testing.db.execute( + select([ + extract(field, fivedaysago)]) + ).scalar() + eq_(r, exp) + class TypeDDLTest(fixtures.TestBase): -- 2.47.2