From 21c4058d92f5f17b87c62063eb77d126be08bd0e Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Sun, 7 Jul 2013 20:54:43 +0100 Subject: [PATCH] sulogin: fix memory leak [clang-analyzer] And make code a little bit more robust. Signed-off-by: Sami Kerola --- login-utils/sulogin-consoles.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/login-utils/sulogin-consoles.c b/login-utils/sulogin-consoles.c index d0f0eab2be..a131e79742 100644 --- a/login-utils/sulogin-consoles.c +++ b/login-utils/sulogin-consoles.c @@ -719,7 +719,7 @@ console: fallback: if (fallback >= 0) { - const char *name; + const char *name, *n; struct console *console; if (device && *device != '\0') @@ -729,7 +729,11 @@ fallback: if (!name) name = "/dev/tty"; - rc = append_console(consoles, strdup(name)); + n = strdup(name); + if (!n) + return -ENOMEM; + rc = append_console(consoles, n); + free(n); if (rc < 0) return rc; if (list_empty(consoles)) -- 2.47.2