From 21e089bc770a7a15250db89ccb1e4a228cd1c1db Mon Sep 17 00:00:00 2001 From: jaskiratsingh Date: Tue, 2 Apr 2019 22:44:48 +0530 Subject: [PATCH] Pool logging documentation bug --- lib/sqlalchemy/engine/__init__.py | 8 ++++---- lib/sqlalchemy/pool/base.py | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/sqlalchemy/engine/__init__.py b/lib/sqlalchemy/engine/__init__.py index a759d648ce..ac53fa637f 100644 --- a/lib/sqlalchemy/engine/__init__.py +++ b/lib/sqlalchemy/engine/__init__.py @@ -170,10 +170,10 @@ def create_engine(*args, **kwargs): information on how to configure logging directly. :param echo_pool=False: if True, the connection pool will log - all checkouts/checkins to the logging stream, which defaults to - sys.stdout. This flag ultimately controls a Python logger; see - :ref:`dbengine_logging` for information on how to configure logging - directly. + all pool disconnects and whether reconnection attempts have exhausted + or not to the logging stream, which defaults to sys.stdout. This flag + ultimately controls a Python logger; see :ref:`dbengine_logging` for + information on how to configure logging directly. :param empty_in_strategy: The SQL compilation strategy to use when rendering an IN or NOT IN expression for :meth:`.ColumnOperators.in_` diff --git a/lib/sqlalchemy/pool/base.py b/lib/sqlalchemy/pool/base.py index 31e1385365..b0fdc82fbe 100644 --- a/lib/sqlalchemy/pool/base.py +++ b/lib/sqlalchemy/pool/base.py @@ -105,10 +105,10 @@ class Pool(log.Identified): "sqlalchemy.pool" logger. Defaults to a hexstring of the object's id. - :param echo: If True, connections being pulled and retrieved - from the pool will be logged to the standard output, as well - as pool sizing information. Echoing can also be achieved by - enabling logging for the "sqlalchemy.pool" + :param echo: if True, the connection pool will log + all pool disconnects and whether reconnection attempts have exhausted + or not to the logging stream, which defaults to sys.stdout. Echoing + can also be achieved by enabling logging for the "sqlalchemy.pool" namespace. Defaults to False. :param use_threadlocal: If set to True, repeated calls to -- 2.47.3