From 23a87f27b1837bd35bea356f0a10816fb35826f2 Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Wed, 23 Jul 2025 22:57:01 -0700 Subject: [PATCH] bluez: Fix invalid-pp-token warning found with clang We add FIRMWARE_DIR via CFLAGS using escapes for string and clang option parser flags it :4:23: warning: missing terminating '"' character [-Winvalid-pp-token] 4 | #define FIRMWARE_DIR \"/usr/lib/firmware\" | ^ emitting this warning during configure means some tests fail wrongly. e.g. test for enable -fPIC -DPIC, which results in textrels in libbbluetooth.so Pass the string definition using single quotes to avoid the shell "eating" the quotes and other characters This works well across gcc and clang Signed-off-by: Khem Raj Signed-off-by: Mathieu Dubois-Briand Signed-off-by: Richard Purdie --- meta/recipes-connectivity/bluez5/bluez5.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc index 3b414433cf..48aeff0aee 100644 --- a/meta/recipes-connectivity/bluez5/bluez5.inc +++ b/meta/recipes-connectivity/bluez5/bluez5.inc @@ -81,7 +81,7 @@ EXTRA_OECONF = "\ --without-zsh-completion-dir \ " -CFLAGS += "-DFIRMWARE_DIR=\\"${nonarch_base_libdir}/firmware\\"" +CFLAGS += "-DFIRMWARE_DIR='"${nonarch_base_libdir}/firmware"'" # bluez5 builds a large number of useful utilities but does not # install them. Specify which ones we want put into ${PN}-noinst-tools. -- 2.47.2