From 24735771774954fa0ebbe0dfa285752647d327f0 Mon Sep 17 00:00:00 2001 From: Dongsheng Yang Date: Mon, 1 Sep 2025 05:42:18 +0000 Subject: [PATCH] dm-pcache: cleanup: fix coding style report by checkpatch.pl A patch from a few days ago fixed the division issue on 32-bit machines, but it introduced a coding style problem. WARNING: Missing a blank line after declarations + u32 rem; + div_u64_rem(off >> PCACHE_CACHE_SUBTREE_SIZE_SHIFT, cache->n_ksets, &rem); total: 0 errors, 1 warnings, 634 lines checked Signed-off-by: Dongsheng Yang Signed-off-by: Mikulas Patocka --- drivers/md/dm-pcache/cache.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-pcache/cache.h b/drivers/md/dm-pcache/cache.h index 66eb20441409d..1136d86958c8c 100644 --- a/drivers/md/dm-pcache/cache.h +++ b/drivers/md/dm-pcache/cache.h @@ -372,9 +372,11 @@ static inline void *get_key_head_addr(struct pcache_cache *cache) static inline u32 get_kset_id(struct pcache_cache *cache, u64 off) { - u32 rem; - div_u64_rem(off >> PCACHE_CACHE_SUBTREE_SIZE_SHIFT, cache->n_ksets, &rem); - return rem; + u32 kset_id; + + div_u64_rem(off >> PCACHE_CACHE_SUBTREE_SIZE_SHIFT, cache->n_ksets, &kset_id); + + return kset_id; } static inline struct pcache_cache_kset *get_kset(struct pcache_cache *cache, u32 kset_id) -- 2.47.3