From 24bb24220c8521412ac33b77b92d7442f6f04815 Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Fri, 22 Oct 2010 18:34:27 -0700 Subject: [PATCH] A better fix for Bug 577053: We only upgrade an old workflow to a new one if we're upgrading from a version of Bugzilla before 4.0, and we figure this out now by checking the existence of bugs_activity.comment_id. r=LpSolit, a=mkanat --- Bugzilla/Install/DB.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm index 687e8b83b0..d3dcc175b7 100644 --- a/Bugzilla/Install/DB.pm +++ b/Bugzilla/Install/DB.pm @@ -2964,10 +2964,9 @@ sub _initialize_workflow_for_upgrade { } # We only populate the workflow here if we're upgrading from a version - # before 4.0 (which is where init_workflow was added). - my $new_exists = $dbh->selectrow_array( - 'SELECT 1 FROM bug_status WHERE value = ?', undef, 'NEW'); - return if !$new_exists; + # before 4.0 (which is where init_workflow was added). This was the + # first schema change done for 4.0, so we check this. + return if $dbh->bz_column_info('bugs_activity', 'comment_id'); # Populate the status_workflow table. We do nothing if the table already # has entries. If all bug status transitions have been deleted, the -- 2.47.2