From 24c228f794fc143af611c5aa84723d6e73d128b2 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 20 Oct 2025 16:10:41 -0400 Subject: [PATCH] gdb: remove return value of set_current_source_symtab_and_line It is never used. Change-Id: I9bbc87a232a2d0f074fefa08f3435aac82cd3dcf Approved-By: Tom Tromey --- gdb/source.c | 21 +++------------------ gdb/source.h | 9 +++------ 2 files changed, 6 insertions(+), 24 deletions(-) diff --git a/gdb/source.c b/gdb/source.c index aee3b92e570..b35d0a5f423 100644 --- a/gdb/source.c +++ b/gdb/source.c @@ -269,30 +269,15 @@ set_default_source_symtab_and_line (void) select_source_symtab (); } -/* Return the current default file for listing and next line to list - (the returned sal pc and end fields are not valid.) - and set the current default to whatever is in SAL. - NOTE: The returned sal pc and end fields are not valid. */ +/* See source.h. */ -struct symtab_and_line +void set_current_source_symtab_and_line (const symtab_and_line &sal) { - symtab_and_line cursal; - - current_source_location *loc = get_source_location (sal.pspace); - - cursal.pspace = sal.pspace; - cursal.symtab = loc->symtab (); - cursal.line = loc->line (); - cursal.pc = 0; - cursal.end = 0; - - loc->set (sal.symtab, sal.line); + get_source_location (sal.pspace)->set (sal.symtab, sal.line); /* Force the next "list" to center around the current line. */ clear_lines_listed_range (); - - return cursal; } /* Reset any information stored about a default file and line to print. */ diff --git a/gdb/source.h b/gdb/source.h index 8a7d2589475..71a3b440ab9 100644 --- a/gdb/source.h +++ b/gdb/source.h @@ -124,12 +124,9 @@ extern symtab_and_line get_current_source_symtab_and_line we have without erroring out or trying to get a default. */ extern void set_default_source_symtab_and_line (void); -/* Return the current default file for listing and next line to list - (the returned sal pc and end fields are not valid.) - and set the current default to whatever is in SAL. - NOTE: The returned sal pc and end fields are not valid. */ -extern symtab_and_line set_current_source_symtab_and_line - (const symtab_and_line &sal); +/* Set the current default file for listing and next line to list to whatever is + in SAL. */ +extern void set_current_source_symtab_and_line (const symtab_and_line &sal); /* Reset any information stored about a default file and line to print. */ extern void clear_current_source_symtab_and_line (program_space *pspace); -- 2.47.3