From 24e8ec5fb2e6d0463d875773cfe8ae8f3a1861a1 Mon Sep 17 00:00:00 2001 From: Keith Seitz Date: Mon, 23 Jul 2012 21:12:34 +0000 Subject: [PATCH] * linespec.c (convert_linespec_to_sal): Don't add any symbols to the result vector if symbol_to_sal returns zero. --- gdb/ChangeLog | 6 ++++++ gdb/linespec.c | 10 +++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 660bb5769be..3e99445c8ba 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2012-07-23 Keith Seitz + + * linespec.c (convert_linespec_to_sal): Don't add + any symbols to the result vector if symbol_to_sal + returns zero. + 2012-07-20 Doug Evans * NEWS: Document new options "set/show use-deprecated-index-sections", diff --git a/gdb/linespec.c b/gdb/linespec.c index 4156694bc4f..c8388b85c61 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -1854,9 +1854,9 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) for (i = 0; VEC_iterate (symbolp, ls->labels.label_symbols, i, sym); ++i) { - symbol_to_sal (&sal, state->funfirstline, sym); - add_sal_to_sals (state, &sals, &sal, - SYMBOL_NATURAL_NAME (sym)); + if (symbol_to_sal (&sal, state->funfirstline, sym)) + add_sal_to_sals (state, &sals, &sal, + SYMBOL_NATURAL_NAME (sym)); } } else if (ls->function_symbols != NULL || ls->minimal_symbols != NULL) @@ -1880,8 +1880,8 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls) { pspace = SYMTAB_PSPACE (SYMBOL_SYMTAB (sym)); set_current_program_space (pspace); - symbol_to_sal (&sal, state->funfirstline, sym); - if (maybe_add_address (state->addr_set, pspace, sal.pc)) + if (symbol_to_sal (&sal, state->funfirstline, sym) + && maybe_add_address (state->addr_set, pspace, sal.pc)) add_sal_to_sals (state, &sals, &sal, SYMBOL_NATURAL_NAME (sym)); } } -- 2.47.2