From 24f52b285276a612996499d2e3368f30fe316dc5 Mon Sep 17 00:00:00 2001 From: Alex Rousskov Date: Sun, 22 May 2016 03:52:02 +1200 Subject: [PATCH] Fix icons loading speed. Since trunk r14100 (Bug 3875: bad mimeLoadIconFile error handling), each icon was read from disk and written to Store one character at a time. I did not measure startup delays in production, but in debugging runs, fixing this bug sped up icons loading from 1 minute to 4 seconds. --- src/mime.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mime.cc b/src/mime.cc index 73211cc3dc..a07564f802 100644 --- a/src/mime.cc +++ b/src/mime.cc @@ -430,7 +430,7 @@ MimeIcon::created(StoreEntry *newEntry) /* read the file into the buffer and append it to store */ int n; char *buf = (char *)memAllocate(MEM_4K_BUF); - while ((n = FD_READ_METHOD(fd, buf, sizeof(*buf))) > 0) + while ((n = FD_READ_METHOD(fd, buf, 4096)) > 0) e->append(buf, n); file_close(fd); -- 2.47.2