From 25542a8973bf2a04c073d41a61ecbfde3f164f67 Mon Sep 17 00:00:00 2001 From: Julian Seward Date: Wed, 10 Sep 2014 21:37:58 +0000 Subject: [PATCH] Update docs w.r.t. status of partially-enabled --read-inline-info. git-svn-id: svn://svn.valgrind.org/valgrind/branches/VALGRIND_3_10_BRANCH@14513 --- NEWS | 18 ++++++++---------- coregrind/m_main.c | 4 +++- docs/xml/manual-core.xml | 22 +++++++++++++--------- none/tests/cmdline1.stdout.exp | 4 +++- none/tests/cmdline2.stdout.exp | 4 +++- 5 files changed, 30 insertions(+), 22 deletions(-) diff --git a/NEWS b/NEWS index e8300d1ccb..c2c1c116b8 100644 --- a/NEWS +++ b/NEWS @@ -92,16 +92,14 @@ significantly improved relative to the 3.9.0 release. * ==================== OTHER CHANGES ==================== -* Unwinding through inlined function calls. By default, stack - unwinding now makes use of Dwarf3 inlined-unwind information if it - is available. The practical effect is that inlined calls become - visible in stack traces. The suppression matching machinery has - been adjusted accordingly. This is controlled by the new option - --read-inline-info=yes|no [yes]. - - In the 3.10.0 beta release(s), inlined unwinding is only enabled for - Memcheck and Helgrind. It is hoped to enable it for all tools in - the 3.10.0 final release. +* Unwinding through inlined function calls. Stack unwinding can now + make use of Dwarf3 inlined-unwind information if it is available. + The practical effect is that inlined calls become visible in stack + traces. The suppression matching machinery has been adjusted + accordingly. This is controlled by the new option + --read-inline-info=yes|no. Currently this is enabled by default + only on Linux and Android targets and only for the tools Memcheck, + Helgrind and DRD. * Valgrind can now read EXIDX unwind information on 32-bit ARM targets. If an object contains both CFI and EXIDX unwind diff --git a/coregrind/m_main.c b/coregrind/m_main.c index b3035c78cb..e7159a8828 100644 --- a/coregrind/m_main.c +++ b/coregrind/m_main.c @@ -167,7 +167,9 @@ static void usage_NORETURN ( Bool debug_help ) " code found in stacks, for all code, or for all\n" " code except that from file-backed mappings\n" " --read-inline-info=yes|no read debug info about inlined function calls\n" -" and use it to do better stack traces [no]\n" +" and use it to do better stack traces. [yes]\n" +" on Linux/Android for Memcheck/Helgrind/DRD\n" +" only. [no] for all other tools and platforms.\n" " --read-var-info=yes|no read debug info on stack and global variables\n" " and use it to print better error messages in\n" " tools that make use of it (Memcheck, Helgrind,\n" diff --git a/docs/xml/manual-core.xml b/docs/xml/manual-core.xml index 77a8d3bcbe..8544084af7 100644 --- a/docs/xml/manual-core.xml +++ b/docs/xml/manual-core.xml @@ -1784,14 +1784,19 @@ need to use them. - + - When enabled, Valgrind will read information about - inlined function calls from DWARF3 debug info. - This slows Valgrind startup and makes it use more memory (typically - for each inlined piece of code, 6 words + the function name), but - it results in more descriptive stacktraces: + When enabled, Valgrind will read information about inlined + function calls from DWARF3 debug info. This slows Valgrind + startup and makes it use more memory (typically for each inlined + piece of code, 6 words and space for the function name), but it + results in more descriptive stacktraces. For the 3.10.0 + release, this functionality is enabled by default only for Linux + and Android targets and only for the tools Memcheck, Helgrind + and DRD. Here is an example of some stacktraces with + : + ==15380== by 0x804850E: main (inlinfo.c:34) ==15380== ==15380== Conditional jump or move depends on uninitialised value(s) -==15380== at 0x8048520: main (inlinfo.c:6)]]> - +==15380== at 0x8048520: main (inlinfo.c:6) +]]> And here are the same errors with : -