From 29a7fe55c557e462457f4fb3dcb25681952b0803 Mon Sep 17 00:00:00 2001 From: Quentin Schulz Date: Wed, 12 Nov 2025 18:48:06 +0100 Subject: [PATCH] cmd: led: fix help text for blink subcommand The blink subcommand actually requires an additional parameter (blink-freq) but not the others. In order to simplify the help text, split the blink subcommand help text from the off|on|toggle subcommands. Then, fix the help text so that it is clear that the frequency is required. While at it, specify the duty cycle. Fixes: ffe2052d6e8a ("dm: led: Add a new 'led' command") Signed-off-by: Quentin Schulz --- cmd/led.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/cmd/led.c b/cmd/led.c index 91fb856ee59..296c07b3b38 100644 --- a/cmd/led.c +++ b/cmd/led.c @@ -118,16 +118,13 @@ int do_led(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) return 0; } -#if defined(CONFIG_LED_BLINK) || defined(CONFIG_LED_SW_BLINK) -#define BLINK "|blink [blink-freq in ms]" -#else -#define BLINK "" -#endif - U_BOOT_CMD( led, 4, 1, do_led, "manage LEDs", - " on|off|toggle" BLINK "\tChange LED state\n" + " on|off|toggle\tChange LED state\n" +#if defined(CONFIG_LED_BLINK) || defined(CONFIG_LED_SW_BLINK) + "led blink \tBlink LED (duty cycle 50%)\n" +#endif "led \tGet LED state\n" "led list\t\tshow a list of LEDs" ); -- 2.47.3